Greptile Summary

This PR relocates Docker server job-history and snapshot storage into the mounted workspace (matching the existing K8s behaviour), and adds per-component warnings when deploy prepare silently discards custom resource_manager, resource_consumer, or launcher configuration. It also improves _relocate_server_storage_to_workspace to warn instead of crash when a present snapshot_persistor lacks the expected nested args.storage.args.root_dir key.

• _prepare_docker now calls _relocate_server_storage_to_workspace for the server role, so Docker and K8s server kits share the same storage-relocation logic.
• New _warn_for_replaced_components helper inspects components before _patch_resources removes them, emitting warnings for any with a non-builtin path or non-empty args.
• _relocate_server_storage_to_workspace distinguishes an absent snapshot_persistor (silent) from a present-but-malformed one (warns), and also now catches TypeError to handle null or unexpected types gracefully.

Confidence Score: 5/5

Safe to merge; all code paths are well-guarded and covered by new tests.

The change is narrowly scoped: it adds a read-then-warn pass before component replacement and wires up Docker server storage relocation that was already working for K8s. The warn-before-mutate ordering is correct, the builtins sets are complete for the current launcher catalogue, and the new tests verify both the happy path (relocation succeeds, no spurious warnings) and the error paths (malformed persistor, custom config discarded). The only edge case noted — a JSON-null snapshot_persistor emitting a misleading warning — has no impact on the core relocation or patching logic.

No files require special attention.

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant CLI as CLI / prepare_deployment
    participant PD as _prepare_docker / _prepare_k8s
    participant PR as _patch_resources
    participant WRC as _warn_for_replaced_components
    participant RSS as _relocate_server_storage_to_workspace
    participant FS as resources.json.default

    CLI->>PD: prepare (kit_info, config)
    PD->>PR: (kit_dir, launcher_id, launcher_path, launcher_args)
    PR->>FS: read resources
    PR->>WRC: components, launcher_id, launcher_path
    WRC-->>PR: emit Warning: (if custom resource_manager / resource_consumer / launcher found)
    PR->>FS: write patched resources (passthrough RM + new launcher)

    alt "role == ROLE_SERVER"
        PD->>RSS: (kit_dir, workspace_mount_path)
        RSS->>FS: read patched resources
        alt snapshot_persistor present
            RSS->>RSS: update snapshot_persistor.args.storage.args.root_dir
            note right of RSS: emit Warning if KeyError / TypeError
        end
        RSS->>RSS: update job_manager.args.uri_root
        RSS->>FS: write relocated resources
    end

    PD-->>CLI: result dict

_{Reviews (7): Last reviewed commit: "Merge branch '2.8' into codex/deploy-pre..." | Re-trigger Greptile}